Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved navbar links and responsive design across pages. #149

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Improved navbar links and responsive design across pages. #149

merged 2 commits into from
Oct 4, 2024

Conversation

synakr
Copy link
Contributor

@synakr synakr commented Oct 4, 2024 •
edited by aslams2020
Loading

closes #131

appearances.html

  1. "home" and "contact" in nav bar for appearances.html was activated initially and at the bottom of the pages => fixed and "appearances" is activated for the whole page
  2. Improved responsive design => below 1020px screen width the logo and search bar position were shifted to right and left side respectively, now they are a center
  3. The ironman logo is not linked to the index webpage => its linked now
  4. created focus in the search bar

index.html

  1. when home or about is clicked the section comes out to be overlapping with the navbar => so improved it's response so that when they are clicked the section comes just below the navbar, hence no overlapping
  2. Improved responsive design => below 1020px screen width the logo and search bar position were shifted to right and left side respectively, now they are a center

movie.html

  1. the menu drop down was in-functional below 1020px screen width, since script.js wasn't added =>added
  2. the "about" and "contact" buttons wasn't linked to index => solved
  3. linked the logo too

videos.html

  1. the menu drop down was in-functional below 1020px screen width, since script.js wasn't added =>added
  2. the "about" and "contact" buttons wasn't linked to index => solved
  3. linked the logo too

synakr added 2 commits October 4, 2024 21:40
@synakr
Improved navbar links and responsive design across pages.
4d6fc23 
### appearances.html 1. Activated "appearances" in the navbar for the whole page instead of "home" and "contact." 2. Improved responsive design: logo and search bar centered below 1020px screen width. 3. Linked the Ironman logo to the index webpage. 4. Added focus to the search bar.  ### index.html 1. Fixed navbar overlap issue when "home" or "about" is clicked, ensuring sections appear below the navbar. 2. Centered logo and search bar below 1020px screen width.  ### movie.html 1. Fixed dropdown menu functionality below 1020px screen width by adding script.js. 2. Linked "about" and "contact" buttons to index. 3. Linked the logo.  ### videos.html 1. Fixed dropdown menu functionality below 1020px screen width by adding script.js. 2. Linked "about" and "contact" buttons to index. 3. Linked the logo.
@synakr
Improved navbar links and responsive design across pages.
fbda774 
### appearances.html
1. Activated "appearances" in the navbar for the whole page instead of "home" and "contact."
2. Improved responsive design: logo and search bar centered below 1020px screen width.
3. Linked the Ironman logo to the index webpage.
4. Added focus to the search bar.

### index.html
1. Fixed navbar overlap issue when "home" or "about" is clicked, ensuring sections appear below the navbar.
2. Centered logo and search bar below 1020px screen width.

### movie.html
1. Fixed dropdown menu functionality below 1020px screen width by adding script.js.
2. Linked "about" and "contact" buttons to index.
3. Linked the logo.

### videos.html
1. Fixed dropdown menu functionality below 1020px screen width by adding script.js.
2. Linked "about" and "contact" buttons to index.
3. Linked the logo.
@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stark-tech-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 4:26pm

github-actions[bot]
github-actions bot reviewed Oct 4, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@synakr
Copy link
Contributor Author

synakr commented Oct 4, 2024

@aslams2020 Thank you for this wonderful opportunity! Got to learn a lot of things through my first contribution. I'd really love to continue this! And the project was really fun and I'd love to work on some more minor flaws. Not flaws actually, but there is always a room for imrovement!
Grateful!!!

@aslams2020 aslams2020 added gssoc-ext Indicates Contributions made to GSSoC Extended'24 hacktoberfest-accepted level2 labels Oct 4, 2024
aslams2020
aslams2020 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Owner

@aslams2020 aslams2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Great Work.

@aslams2020 aslams2020 merged commit 0164289 into aslams2020:main Oct 4, 2024
2 checks passed
@aslams2020
Copy link
Owner

Hi, @synakr
I got My account back today. On next leaderboard update you'll be able to see your points.
Sorry for the inconvenience. Keep contributing.🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@aslams2020 aslams2020 aslams2020 approved these changes

Assignees

@synakr synakr

Labels
gssoc-ext Indicates Contributions made to GSSoC Extended'24 hacktoberfest-accepted level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contradiction between navbar and activity
2 participants
@synakr @aslams2020